Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate diagnostics in hir_typeck/src/cast.rs #115879

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Migrate diagnostics in hir_typeck/src/cast.rs #115879

merged 8 commits into from
Sep 19, 2023

Conversation

clubby789
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2023
compiler-errors
compiler-errors approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@clubby789
Copy link
Contributor Author

I did want to note there's a few places with fcx.ty_to_string previously being wrapped in DelayDm or DecorateLint which are now being done more eagerly. I'm not sure if this causes any issues, or if there's a pre-existing solution for these - will just using a Ty<'tcx> as an arg result in the same output when formatted?

@compiler-errors
Copy link
Member

will just using a Ty<'tcx> as an arg result in the same output when formatted?

Yes, make sure that the types passed in have been resolved (resolve_vars_if_possible) if they have not yet.

@compiler-errors
Copy link
Member

@clubby789 can you double check that all the places you're now using Ty<'_> in diagnostics, those tys have been previously resolve_vars_if_possible'd, and if not, pls add those. The worst regression here would be a _ over a concrete ty, but it's kinda annoying and not hard to protect against.

Then r=me

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clubby789
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Sep 16, 2023

📌 Commit 66392b0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2023
@bors
Copy link
Contributor

bors commented Sep 17, 2023

☔ The latest upstream changes (presumably #115909) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 18, 2023

📌 Commit 9c5de75 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
@bors
Auto merge of rust-lang#115952 - matthiaskrgr:rollup-qzk8t4e, r=matth…
f3984ce 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115869 (Avoid blessing cargo deps's source code in ui tests)
 - rust-lang#115873 (Make `TyKind::Adt`'s `Debug` impl be more pretty)
 - rust-lang#115879 (Migrate diagnostics in `hir_typeck/src/cast.rs`)
 - rust-lang#115930 (coverage: Fix an unstable-sort inconsistency in coverage spans)
 - rust-lang#115931 (Move mobile topbar title creation entirely into JS)
 - rust-lang#115941 (Add myself to .mailmap)
 - rust-lang#115943 (compiletest: Don't swallow some error messages.)
 - rust-lang#115949 (Update browser-ui-test version)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 970ee09 into rust-lang:master Sep 19, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 19, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
@rust-timer
Unrolled build for rust-lang#115879
5dad02c 
Rollup merge of rust-lang#115879 - clubby789:migrate-hir-typeck-cast, r=compiler-errors

Migrate diagnostics in `hir_typeck/src/cast.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@clubby789 @rustbot @compiler-errors @rust-log-analyzer @bors @jackh726